fix(SVGCursorDescriptor): improve CursorSVG typing #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks great. This is a great contribution, thanks a lot! |
wayfarer3130
pushed a commit
that referenced
this pull request
Jul 31, 2023
* fix: improve CursorSVG typing * chore: update api --------- Co-authored-by: Carsten Walther <[email protected]>
sedghi
pushed a commit
that referenced
this pull request
Jul 31, 2023
…#702) * fix(loader): Load colour images correctly when specified Float32Array * feat(streamingVolumeLoader): added IMAGE_VOLUME_LOADING_COMPLETED event (#699) * added IMAGE_VOLUME_LOADING_COMPLETED event * api doc * chore(release): publish [skip ci] * chore(script): add a dev script which should be used for linking (#706) * chore(release): publish [skip ci] * fix(SVGCursorDescriptor): improve CursorSVG typing (#705) * fix: improve CursorSVG typing * chore: update api --------- Co-authored-by: Carsten Walther <[email protected]> * chore(release): publish [skip ci] * feat(segmentation export): add new cornerstone3D segmentation export adapter (#692) * chore(adapters): ability to cache and build ESM modules * wip * refactoring * remove bound ijk which is unnecessary since we moved to world * add data set module to the metadata providers * add a new method to segmentation state * add the new parser * work without rle encode * fix demo for export color * add centroid calculations * add trigger event for segmentation load progress * update dcmjs * update api * fix example * remove the promise await * apply review comments * add adapters section to examples * add adapters dep to docs * add eslint rule * example deploy * chore(release): publish [skip ci] * fix(voi): fix the voi setting when the stack is composed of different orientations (#703) * fix(voi): fix the voi setting when the stack is composed of different orientations * fix the volume conversion to stack voi bug * fix(volumes): a volume should be able to grab data from another cached volume when needed * revert example change * chore(release): publish [skip ci] * feat(voiSync): add optoins to turn of invert sync for voisync (#708) * chore(release): publish [skip ci] * PR requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
CursorSVGhad a implicit type that did not reflect, that cursors for new tool names can be added.registerCursorcan add any string as toolname toCursorSVG.svgCursorNameshas a similar problem. It only returns the initial cursor names.Maybe it should be a function instead of a variable to return the current keys of
CursorSVG.I did not changed it because I did not want to risk changing the public API on my first PR here. :)
Changes & Results
CursorSVGhas a broader type.Small refactoring in
getDefinedSVGCursorDescriptor. Should not affect functionality.Testing
Only typing change. No change in runtime behavior.
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment