Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segmentation export): add new cornerstone3D segmentation export adapter and optimize SEG read #692

Merged
merged 26 commits into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
eaeefe7
chore(adapters): ability to cache and build ESM modules
sedghi May 2, 2023
101e778
wip
sedghi May 4, 2023
5060e3b
update yarn lock
sedghi Jun 19, 2023
7dc9c67
refactoring
sedghi Jul 12, 2023
b25c911
remove bound ijk which is unnecessary since we moved to world
sedghi Jul 12, 2023
f310dec
add data set module to the metadata providers
sedghi Jul 14, 2023
2750e8d
add a new method to segmentation state
sedghi Jul 14, 2023
454da6e
add the new parser
sedghi Jul 14, 2023
9d4ad01
work without rle encode
sedghi Jul 17, 2023
27b0c19
fix demo for export color
sedghi Jul 18, 2023
8917dd0
add centroid calculations
sedghi Jul 19, 2023
2f6655f
add trigger event for segmentation load progress
sedghi Jul 19, 2023
936d9ac
update dcmjs
sedghi Jul 19, 2023
c153d0a
update api
sedghi Jul 19, 2023
87c1e6d
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fe…
sedghi Jul 19, 2023
b6531db
fix example
sedghi Jul 20, 2023
5e9d513
remove the promise await
sedghi Jul 25, 2023
9d59ed9
apply review comments
sedghi Jul 25, 2023
26f95b0
Merge branch 'feat/dicom-seg-adapter' of github.com:cornerstonejs/cor…
sedghi Jul 25, 2023
ceefd3d
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fe…
sedghi Jul 25, 2023
b4afff5
add adapters section to examples
sedghi Jul 26, 2023
cb4ebc5
add adapters dep to docs
sedghi Jul 27, 2023
bdddef0
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fe…
sedghi Jul 27, 2023
2fde8fb
add eslint rule
sedghi Jul 27, 2023
e65febc
example deploy
sedghi Jul 27, 2023
5ae85c7
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fe…
sedghi Jul 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@
"tsconfigRootDir": "./"
},
"rules": {
// Enforce consistent brace style for all control statements for readability
"curly": "error",
"tsdoc/syntax": "warn",
"@typescript-eslint/ban-ts-comment": "off",
"no-console": [
Expand Down
4 changes: 4 additions & 0 deletions common/reviews/api/tools.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2017,6 +2017,9 @@ function getActiveSegmentationRepresentation(toolGroupId: string): ToolGroupSpec
// @public (undocumented)
function getActiveSegmentIndex(segmentationId: string): number | undefined;

// @public (undocumented)
function getAllSegmentationRepresentations(): Record<string, ToolGroupSpecificRepresentation[]>;

// @public (undocumented)
function getAllSynchronizers(): Array<Synchronizer>;

Expand Down Expand Up @@ -4899,6 +4902,7 @@ declare namespace state_3 {
getSegmentSpecificRepresentationConfig,
setSegmentSpecificRepresentationConfig,
getToolGroupIdsWithSegmentation,
getAllSegmentationRepresentations,
getSegmentationRepresentationByUID,
addColorLUT,
getColorLUT,
Expand Down
2 changes: 1 addition & 1 deletion nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"default": {
"runner": "nx/tasks-runners/default",
"options": {
"cacheableOperations": ["build", "test"]
"cacheableOperations": ["build", "test", "build:esm"]
}
}
},
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build": "npx lerna run build --stream",
"build:esm": "npx lerna run build:esm --stream",
"build:umd": "npx lerna run build:umd --stream",
"watch": "npx lerna watch -- lerna run build --scope=$LERNA_PACKAGE_NAME --include-dependents",
"build:update-api:core": "cd packages/core && npm run build:update-api",
"build:update-api:tools": "cd packages/tools && npm run build:update-api",
"build:update-api:adapters": "cd packages/adapters && npm run build:update-api",
Expand Down
4 changes: 0 additions & 4 deletions packages/adapters/config/webpack/index.js

This file was deleted.

15 changes: 0 additions & 15 deletions packages/adapters/config/webpack/merge.js

This file was deleted.

30 changes: 0 additions & 30 deletions packages/adapters/config/webpack/webpack-base.js

This file was deleted.

16 changes: 0 additions & 16 deletions packages/adapters/config/webpack/webpack-dev.js

This file was deleted.

16 changes: 0 additions & 16 deletions packages/adapters/config/webpack/webpack-prod.js

This file was deleted.

21 changes: 0 additions & 21 deletions packages/adapters/examples/index.html

This file was deleted.

Loading