fix(examples): fix the stack and volume segmentation adapters example #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…toolbar functionality - Consolidated segmentation-related functions into a new utils module for better organization. - Updated toolbar buttons to utilize the new state management for DICOM and SEG file handling. - Enhanced user instructions for loading and exporting segmentation data. - Introduced a toggle for handling overlapping segments during segmentation loading. - Improved event handling for file selection and drag-and-drop functionality. - Refactored rendering engine and viewport setup for clarity and maintainability.
sedghi
changed the title
|
@sedghi thank you for the fixes! In Volume viewport example https://www.cornerstonejs.org/live-examples/segmentationvolume I press Import DICOM and choose some CT files, and nothing happens (tried all browsers) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1679
fixes #1661
fixes #664
fixes #1188
This pull request introduces several new functions and refactors existing ones to improve the handling of DICOM files and segmentation in the Cornerstone library. The changes include adding new utility functions for reading, loading, and exporting DICOM and segmentation files, as well as refactoring the
generateToolStatefunction to use more descriptive parameter names.New Utility Functions:
packages/adapters/examples/segmentationVolume/utils.ts: Added functionsreadDicom,readSegmentation,loadSegmentation,exportSegmentation,restart,getSegmentationIds,handleFileSelect, andhandleDragOverto handle DICOM file operations and segmentation processes.Refactoring:
packages/adapters/src/adapters/Cornerstone/Segmentation_4X.js: Refactored thegenerateToolStatefunction to replaceimageIdswithreferencedImageIdsfor better clarity and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9]Event Handling Improvements:
packages/tools/src/eventListeners/mouse/mouseMoveListener.ts: Added a check to ensureenabledElementis not null before proceeding with the mouse move event handling.packages/tools/src/eventListeners/segmentation/imageChangeEventListener.ts: Added checks to ensureelementandenabledElementare not null before enabling segmentation.Utility Enhancements:
packages/tools/src/utilities/planar/filterAnnotationsForDisplay.ts: Added a check to ensureimageIdis not null before proceeding with filtering annotations for display.