Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PlanarFreehandROITool) Issue 1297 - PlanarFreehandROITool decimate configuration parameter not working on annotation update #1298

Conversation

kom482
Copy link
Contributor

@kom482 kom482 commented May 30, 2024

Context

Issue 1297

The decimate configuration parameter in the PlanarFreehandROITool is not functioning as expected when updating an annotation. Specifically, changes to the decimate parameter are not applied to existing annotations.

Changes & Results

decimate parameter added to updateContourPolyline function for openContourEditLoop and closedContourEditLoop

Before: Issue 1297
After:
https://github.com/cornerstonejs/cornerstone3D/assets/2040590/33266e90-85e4-4256-afbc-9f8fd66ddce0

Testing

  1. Set PlanarFreehandROITool Configuration with decimate parameter
  toolGroup.setToolConfiguration(PlanarFreehandROITool.toolName, {
    calculateStats: true,
    decimate: {
      enabled: true,
      epsilon: 5
    }
  });
  1. Create an annotation using PlanarFreehandROITool
  2. Update annotation

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • (N/A) My code has been well-documented (function documentation, inline comments,
    etc.)

  • (N/A) I have run the yarn build:update-api to update the API documentation, and have
    committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)

Public Documentation Updates

  • (N/A) The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Windows 11
  • "Node version: 16.20.2
  • "Browser: Chrome 125.0.6422.113

Copy link

netlify bot commented May 30, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit cd97cc6
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6658dc252e3c1500092742aa
😎 Deploy Preview https://deploy-preview-1298--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants