Remove version parsing for torch nightlies, req. >=1.0.1 instead #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2019
gpleiss
approved these changes
Apr 24, 2019
|
Hmm actually there seems to be a difference in how this is dealt with between pip and conda. In particular, if the |
|
argh apparently there is a bug in pip 19.0.1 that shows up in conjunction with having a pyproject.toml file (which we do) that always results in setup.py not being able to import torch: pypa/pip#6163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this is unnecessary. Requiring
"torch>=1.0.1"will not install stable if a dev version from the nightlies is present.Addresses #662