Remove Module.__getattr__

[saitcakmak]

GPyTorch Module class defines a custom __getattr__ method that used to serve a purpose, but now only calls super().__getattr__. This leads to deepening of stack trace and can cause mild confusion. Since it is a no-op, removing it seems like the right move to me.

Aside: First calling __getattr__ then falling back to __getattribute__ is a bit strange on its own. Python first calls __getattribute__ and if an attribute is not found __getattr__ is invoked, in case there's some custom logic. Looking at the changelog, it seems like __getattribute__ was called using some base_name when this wasn't a no-op, so it's probably a relic from those times.

[gpleiss]

I think this should be fine!

[Balandat]

Not sure this is relevant, just pointing out that pytorch overrides __getattr__ in a way that can sometimes cause unintiutive behavior: https://github.com/pytorch/pytorch/blob/main/torch/nn/modules/module.py#L1617-L1631. But it seems here this is indeed a noop.

[saitcakmak]

Yeah, PyTorch overwrites both __getattr__ and __setattr__. There's a known bug where some properties can effectively become inaccessible but fixing it leads to backwards-incompatible changes as I've found out (fix got reverted, the bug is still there).