Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid evaluating kernel in expand_batch #2185

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

dannyfriar
Copy link
Contributor

@dannyfriar dannyfriar commented Nov 3, 2022

This is a very similar case to #2140.

Not necessarily expecting this to be merged as is but just curious to see if anything breaks with this tiny change. This also results in materialising the NxN matrix in some cases.

Copy link
Member

@gpleiss gpleiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait till the add_jitter PR is merged before merging this.

@gpleiss gpleiss enabled auto-merge (squash) November 28, 2022 20:57
@gpleiss gpleiss merged commit 93623d9 into cornellius-gp:master Nov 29, 2022
@dannyfriar
Copy link
Contributor Author

@gpleiss what is the expected release cadence for GPyTorch? I just wanted to get an idea of when I can expect this to be available in pypi.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants