-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with PeriodicKernel.diag() #1919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but for the inline question
- Refactor PerodicKernel + docs - Improve tests [Fixes #1915]
I'm wondering if we should also fix #1020 while we're at it - the lengthscale parameter is inconsistent with our other kernels (i.e. we should be squaring the lengthscale parameter). This would be a breaking change though... thoughts? Of course, we should save this for a different PR. |
@Balandat ready for a second review / merge. |
I have never really participated in PRs, so let me know if my comment is useful or not. I tried the PR on my code and it fixed the bug I described in pytorch/botorch#1112. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpleiss this lgtm.
[Fixes #1915]
[Fixes #1926]