Update min PyTorch version to 1.9, resolve deprecation warnings #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpleiss
force-pushed
the
fix_warnings
branch
from
c0e05e3
to
01f2987
Compare
gpleiss
changed the title
gpleiss
force-pushed
the
fix_warnings
branch
from
9767b7d
to
eb023c4
Compare
|
It seems a bit aggressive to jump from 1.8.1 min req to 1.10 skipping 1.9, and just one month after 1.10 was released. This could mean a lot of folks that are using this in a prod setting and who may be able to upgrade gpytorch but not torch would not be able to use this for a while. Are there any warnings that were issued starting with 1.9? If so coudl we split those out and make a release that requires 1.9, and then merge the rest of this? |
|
Okay yeah that's fair. There was only one minor 1.10-specific warning. I'll split that out |
gpleiss
force-pushed
the
fix_warnings
branch
from
eb023c4
to
1c46ed6
Compare
gpleiss
changed the title
Balandat
approved these changes
Nov 22, 2021
Comment on lines
+55
to
+56
| row_index_block = torch.div(row_index, self.base_lazy_tensor.size(-2), rounding_mode="floor") | ||
| col_index_block = torch.div(col_index, self.base_lazy_tensor.size(-1), rounding_mode="floor") |
There was a problem hiding this comment.
Suggested change
| row_index_block = torch.div(row_index, self.base_lazy_tensor.size(-2), rounding_mode="floor") | |
| col_index_block = torch.div(col_index, self.base_lazy_tensor.size(-1), rounding_mode="floor") | |
| row_size, col_size = self.base_lazy_tensor.shape[-2:] | |
| row_index_block = torch.div(row_index, row_size, rounding_mode="floor") | |
| col_index_block = torch.div(col_index, col_size, rounding_mode="floor") |
Comment on lines
+56
to
+57
| row_index = torch.div(row_index, self.base_lazy_tensor.size(-3), rounding_mode="floor") | ||
| col_index = torch.div(col_index, self.base_lazy_tensor.size(-3), rounding_mode="floor") |
There was a problem hiding this comment.
Suggested change
| row_index = torch.div(row_index, self.base_lazy_tensor.size(-3), rounding_mode="floor") | |
| col_index = torch.div(col_index, self.base_lazy_tensor.size(-3), rounding_mode="floor") | |
| block_dim = self.base_lazy_tensor.size(-3) | |
| row_index = torch.div(row_index, block_dim, rounding_mode="floor") | |
| col_index = torch.div(col_index, block_dim, rounding_mode="floor") |
|
oops so much for the suggestions, auto-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of new deprecation warnings due to PyTorch 1.10 (plus some other warnings that we've previously missed). This PR addresses all warnings that pop up in the test suite.
This should hopefully be an easy merge.