✨ [Story Preview] Handle page advancement logic when transitioning from the preview state to visible
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o visibility state changes
…his.advancement_ gets initialized in non-preview/visible states
coreymasanto
changed the title
preview state to visible
coreymasanto
changed the title
preview state to visiblepreview state to visible
…r transitioning from preview mode to visible mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes the story page to do the following:
Re-initialize
this.advancement_when moving from the preview state to visible. The advancement in preview mode is a time-based one whereas it should not necessarily be time-based in visible modeThe new
setupAutoAdvanceForVisible_()function is used to help restore the page's advancement to its default, non-preview behavior expectedThe new
handlePreviewToVisibleTransition_()function is designed to ensure that the progress bar accurately reflects the page's progress invisiblemode, specifically after transitioning out ofpreviewmode.