Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Modeling Source and Line Resistances for 1.1.4 Release #98

Merged
merged 112 commits into from
Sep 21, 2021

Conversation

coreylammie
Copy link
Owner

  • Added support for modeling source and line resistances for passive crossbars/tiles.
  • Added C++ and CUDA bindings for modeling source and line resistances for passive crossbars/tiles*.
  • Added a new MemTorch logo to README.md.
  • Added the set_cuda_malloc_heap_size routine to patched torch.mn modules.
  • Added unit tests for source and line resistance modeling.
  • Updated ReadTheDocs documentation.
  • Transitioned from Gitter to GitHub Discussions for general discussion.

*Note It is strongly suggested to set cuda_malloc_heap_size using m.set_cuda_malloc_heap_size manually when simulating source and line resistances using CUDA bindings.

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #98 (8ed3030) into master (e6825bb) will decrease coverage by 6.23%.
The diff coverage is 32.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   90.76%   84.53%   -6.24%     
==========================================
  Files          54       54              
  Lines        2058     2269     +211     
==========================================
+ Hits         1868     1918      +50     
- Misses        190      351     +161     
Flag Coverage Δ
unittests 84.53% <32.64%> (-6.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nce_retention_models/empirical_metal_oxide_RRAM.py 100.00% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
memtorch/bh/crossbar/Passive.py 4.37% <4.37%> (ø)
memtorch/mn/Module.py 83.05% <40.00%> (-3.99%) ⬇️
memtorch/bh/crossbar/Tile.py 79.41% <60.71%> (-5.68%) ⬇️
memtorch/mn/Conv1d.py 94.56% <75.00%> (-4.17%) ⬇️
memtorch/mn/Conv2d.py 93.68% <75.00%> (-3.88%) ⬇️
memtorch/mn/Conv3d.py 93.75% <75.00%> (-3.85%) ⬇️
memtorch/mn/Linear.py 91.95% <75.00%> (-4.00%) ⬇️
memtorch/bh/crossbar/Crossbar.py 91.95% <100.00%> (-0.05%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6825bb...8ed3030. Read the comment docs.

@coreylammie coreylammie merged commit 0dfdbe1 into master Sep 21, 2021
@coreylammie coreylammie deleted the line_resistance branch September 21, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interconnect Line Resistances and the Source Resistance Are Not Accounted For
1 participant