Stop using process.umask()

Ref nodejs/node#32321
coreyfarrell · May 4, 2020 · f345cf3 · f345cf3
1 parent fe502f4
commit f345cf3
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/mkdirp.js b/mkdirp.js
@@ -13,7 +13,7 @@ function mkdirp(dirpath, customMode, callback) {
     customMode = undefined;
   }
 
-  var mode = customMode || DEFAULT_DIR_MODE & ~process.umask();
+  var mode = customMode || DEFAULT_DIR_MODE;
   dirpath = path.resolve(dirpath);
 
   fs.mkdir(dirpath, mode, onMkdir);
@@ -46,12 +46,12 @@ function mkdirp(dirpath, customMode, callback) {
         return callback(mkdirErr);
       }
 
-      // TODO: Is it proper to mask like this?
-      if ((stats.mode & MASK_MODE) === mode) {
+      if (!customMode) {
         return callback();
       }
 
-      if (!customMode) {
+      // TODO: Is it proper to mask like this?
+      if ((stats.mode & MASK_MODE) === mode) {
         return callback();
       }
 
@@ -64,7 +64,7 @@ function mkdirp(dirpath, customMode, callback) {
       return callback(recurseErr);
     }
 
-    mkdirp(dirpath, mode, callback);
+    mkdirp(dirpath, customMode, callback);
   }
 }