Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print skip message for disabled tests #56

Merged
merged 3 commits into from
May 29, 2022
Merged

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Apr 25, 2022

Use File.Seek() to move to end of file for next read

Use File.Seek() to move to end of file for next read
Copy link
Collaborator

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Only some minor changes.

config/config_test.go Outdated Show resolved Hide resolved
runner/run.go Outdated Show resolved Hide resolved
waflog/waflog.go Outdated Show resolved Hide resolved
waflog/waflog.go Show resolved Hide resolved
waflog/waflog.go Show resolved Hide resolved
waflog/waflog_test.go Show resolved Hide resolved
runner/run_test.go Outdated Show resolved Hide resolved
@fzipi fzipi force-pushed the open-log-file-only-once branch from 8483b81 to 104fd54 Compare May 28, 2022 14:07
@fzipi fzipi requested a review from theseion May 28, 2022 14:07
@fzipi fzipi force-pushed the open-log-file-only-once branch from 104fd54 to 9fc95b8 Compare May 28, 2022 14:10
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.3% 87.3% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi fzipi merged commit 9ace87c into main May 29, 2022
@fzipi fzipi deleted the open-log-file-only-once branch May 29, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants