Use the local test web server for all tests #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issues with false positive test results
|
Note: not all tests will succeed. Originally, some tests succeeded even though they shouldn't have. After fixing that, they now fail. That will be cleaned up with introduction of log marking. |
Merged
fzipi
reviewed
Mar 20, 2022
runner/run.go
Outdated
| @@ -35,6 +36,7 @@ func Run(include string, exclude string, showTime bool, output bool, ftwtests [] | |||
| // if we received a particular testid, skip until we find it | |||
| if needToSkipTest(include, exclude, t.TestTitle, tests.Meta.Enabled) { | |||
| addResultToStats(Skipped, t.TestTitle, &stats) | |||
| log.Info().Msgf("Skipping test %s", t.TestTitle) | |||
There was a problem hiding this comment.
The problem here is that we cannot control if this is logged in quiet mode.
There was a problem hiding this comment.
I've changed it to respect quiet mode. Better?
|
So we should merge this one despite tests failing? |
|
Depends. The other PR is based on this one, so it includes these changes too. I just wanted to separate the change. Tests in the other PR are all green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with false positive test results