Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't trace log when skipping lines #405

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

theseion
Copy link
Collaborator

When using -n to run a single line only, trace logging will log every single line. Stop doing that.

When using `-n` to run a single line only, trace logging will log every
single line. Stop doing that.
@theseion theseion closed this Nov 24, 2024
@theseion theseion requested a review from fzipi November 24, 2024 15:28
@theseion theseion reopened this Nov 24, 2024
Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I thought there was no limit on being verbose with Trace 😅

@theseion theseion merged commit d69a1f0 into coreruleset:main Nov 24, 2024
7 checks passed
@theseion theseion deleted the dont-trace-line-skips branch November 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants