Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor fixes, false positives ratio printed #390

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Nov 4, 2024

No description provided.

@M4tteoP M4tteoP marked this pull request as ready for review November 4, 2024 15:14
@fzipi
Copy link
Member

fzipi commented Nov 4, 2024

Minor ask: can you add the time in seconds that it took to run in the json output?

We have this totalTime, which makes sense but it doesn't show properly:

{"count":10000,"falsePositives":408,"falsePositivesPerRule":{"920220":198,"920221":198,"932235":4,"932270":2,"932380":2,"933160":1,"942100":1,"942230":1,"942360":1},"totalTime":4356441750}

@M4tteoP
Copy link
Member Author

M4tteoP commented Nov 4, 2024

PTAL, moved to Seconds and renamed the variable:

▶ go run main.go quantitative --crs-path ~/Repo/coreruleset --corpus-size "10k" -o json | jq .
11:45PM INF ⏳Running quantitative tests with 10 goroutines
{
  "count": 10000,
  "falsePositives": 10407,
  "falsePositivesPerRule": {
    "920220": 198,
    "920221": 198,
    "932235": 4,
    "932270": 2,
    "932380": 2,
    "933160": 10000,
    "942100": 1,
    "942230": 1,
    "942360": 1
  },
  "totalTimeSeconds": 1.63549225
}

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi fzipi merged commit 15ad5a1 into coreruleset:main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants