This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
cache: put cache data after writing the data successfully #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Dec 12, 2016
| @@ -180,11 +180,11 @@ func (d *Distributor) WriteBlock(ctx context.Context, i torus.BlockRef, data []b | |||
| if len(peers.Peers) == 0 { | |||
| return torus.ErrOutOfSpace | |||
| } | |||
| d.readCache.Put(string(i.ToBytes()), data) | |||
There was a problem hiding this comment.
var err error
defer func() {
if err == nil {
d.readCache.Put(...)
}
}
|
How did you spot this bug? do you mind adding a test for this? |
|
Thank you. I updated. Sure, I can add a test for this. But it looks like I should wait for #359, as some test utilities would be added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache: put cache data after writing the data successfully
This patch changes the cache data to put after writing the data to local or peers successfully.
As current code put the cache before writing the data, it causes conflict when the writing the data failed.