Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

Commit

Permalink
Revert "disk_util: use FAT32 on ESP"
Browse files Browse the repository at this point in the history
This reverts commit 7f058d6.

Reverting because of bug 2284 [1] where grub will sometimes fail due to
memory corruption. This is _not_ the cause of the bug, and the bug can
even be reproduced with this reversion, but it seems to occur less when
not using fat32.

[1] coreos/bugs#2284
  • Loading branch information
Andrew Jeddeloh committed Dec 18, 2017
1 parent 7ab2b63 commit 299f8fb
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions build_library/disk_util
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,6 @@ def FormatFat(part, device):
cmd = ['mkfs.vfat']
if 'fs_label' in part:
cmd += ['-n', part['fs_label']]
if part['type'] == 'efi':
# ESP is FAT32 irrespective of size
cmd += ['-F', '32']
Sudo(cmd + [device, vfat_blocks], stdout_null=True)


Expand Down

0 comments on commit 299f8fb

Please sign in to comment.