override: Add --cache-only flag #3153
Conversation
|
Skipping CI for Draft Pull Request. |
|
(not tested) |
| @@ -43,6 +44,7 @@ static GOptionEntry option_entries[] = { | |||
| { "reboot", 'r', 0, G_OPTION_ARG_NONE, &opt_reboot, "Initiate a reboot after operation is complete", NULL }, | |||
| { "dry-run", 'n', 0, G_OPTION_ARG_NONE, &opt_dry_run, "Exit after printing the transaction", NULL }, | |||
| { "lock-finalization", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_NONE, &opt_lock_finalization, "Prevent automatic deployment finalization on shutdown", NULL }, | |||
| { "cache-only", 'C', 0, G_OPTION_ARG_NONE, &opt_cache_only, "Do not download latest ostree and RPM data", NULL }, | |||
There was a problem hiding this comment.
| { "cache-only", 'C', 0, G_OPTION_ARG_NONE, &opt_cache_only, "Do not download latest ostree and RPM data", NULL }, | |
| { "cache-only", 'C', 0, G_OPTION_ARG_NONE, &opt_cache_only, "Do not download RPM data", NULL }, |
There was a problem hiding this comment.
True...today. But, I could imagine us changing this in the future...let's say we detect that in order to solve dependencies, we need to update the base ostree. We don't do this today, but we could.
There was a problem hiding this comment.
We could perhaps make this more generic and say "Only operate on cached data"?
There was a problem hiding this comment.
I feel like us not doing that automatically (unlike dnf) is an advantage. But definitely open to discuss in the future.
We could perhaps make this more generic and say "Only operate on cached data"?
Sure, SGTM!
cgwalters
force-pushed
the
override-cache-only
branch
from
a729132 to
5353062
Compare
|
OK this came up again on internal chat; rebased 🏄 fixed the comment and lifting draft. |
For the same reason we have it elsewhere. Fetching the repomd is a fine default, but e.g. someone may want to try overriding using a local package that doesn't need any dependencies when the machine is offline, or for some reason the rpm-md repositories aren't accessible. Motivated by trying to work around an OpenShift MCO issue where it only provisions an rpm-md repo transitively.
cgwalters
force-pushed
the
override-cache-only
branch
from
5353062 to
3a7a982
Compare
|
Rebased 🏄 to pick up CI fixes - this one just needs a re-stamp |
For the same reason we have it elsewhere. Fetching the repomd
is a fine default, but e.g. someone may want to try overriding
using a local package that doesn't need any dependencies when
the machine is offline, or for some reason the rpm-md repositories
aren't accessible.
Motivated by trying to work around an OpenShift MCO issue where
it only provisions an rpm-md repo transitively.