[merged] tests: Introduce "vmcheck" #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is infrastructure that's oriented around Vagrant, we do builds inside the target VM (actually inside a Docker container), but then directly `make install DESTDIR=/host/`. The goal here is to have a convenient workflow for: - dev -> hand testing - dev -> run destructive tests
| register: inspect | ||
|
|
||
| - name: build buildimg | ||
| command: make buildimg |
There was a problem hiding this comment.
I had to add this here:
args:
chdir: sync/tests/vmcheck
|
Fixup 🔧 ⬆️ |
|
Obviously there's a pile of hacks in here. It does something useful, but I'm still uncertain about the maintenance cost vs how useful it is. I am already hitting the pain that it doesn't help one build ostree or libhif. A clear generalization of this is to move https://github.com/cgwalters/rpmdistro-gitoverlay more towards being a convenient tool for local development. |
|
Right, this is going to require some further tweaking before we can start using it for tests. But I'm OK with getting it in and fixing it up there. |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is infrastructure that's oriented around Vagrant, we do builds
inside the target VM (actually inside a Docker container), but then
directly
make install DESTDIR=/host/.The goal here is to have a convenient workflow for: