tests/vmcheck: Fully drop python 3 requirement #1850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've only tested a subset of the tests with this, so marking as WIP to let CI test everything else. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 7, 2019
Drop the use of Ansible everywhere. And for now, just disable the one test that directly uses Python on the host. This is required to be able to hack on Fedora CoreOS. Closes: #1850 Approved by: cgwalters
|
If this passes CI I'm good with it. |
Drop the use of Ansible everywhere. In the few cases where we really Python, just spawn a container instead. This is required to be able to hack on Fedora CoreOS.
|
OK, this was trickier than expected because we also used the py3 http server. Ended up just adding some helpers to spawn containers. Also had to tweak the |
|
Sorry, I mistakenly nuked your fixup in the process of adding my fixup. Restored now! |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 10, 2019
Drop the use of Ansible everywhere. In the few cases where we really Python, just spawn a container instead. This is required to be able to hack on Fedora CoreOS. Closes: #1850 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 10, 2019
Drop the use of Ansible everywhere. In the few cases where we really Python, just spawn a container instead. This is required to be able to hack on Fedora CoreOS. Closes: #1850 Approved by: jlebon
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 10, 2019
Drop the use of Ansible everywhere. In the few cases where we really Python, just spawn a container instead. This is required to be able to hack on Fedora CoreOS. Closes: #1850 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the use of Ansible everywhere. And for now, just disable the one
test that directly uses Python on the host.
This is required to be able to hack on Fedora CoreOS.