Misc patches #1823
Closed
Misc patches #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `out_printed_cached_update` and `sysroot_proxy` to be `NULL`. This will be the case for the history feature, which will reuse the same code for printing.
For the history work, I'd like to be able to retrieve the full GVariant, which includes the whole unfiltered layered and base commit metadata. So let's add an argument to allow not filtering those.
Will be used by the history work.
|
I haven't dived into the client side code yet but these small patches seem pretty straight forward and code LGTM. |
|
Thanks! |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 1, 2019
For the history work, I'd like to be able to retrieve the full GVariant, which includes the whole unfiltered layered and base commit metadata. So let's add an argument to allow not filtering those. Closes: #1823 Approved by: mike-nguyen
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 1, 2019
Will be used by the history work. Closes: #1823 Approved by: mike-nguyen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More minor patches split out of #1813.