-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: Add Cargo.lock #1719
rust: Add Cargo.lock #1719
Conversation
We've been seeing more breakage recently due to much of the Rust ecosystem sticking to minimum rustc versions more recent than ours. A lockfile now means we have to periodically update it, but at least we have much better control over our CI system and when we want to spend time resolving package bump conflicts vs. just trying to get a small patch in.
👍 The idea is that top-level consumers (i.e. applications) lock their dependencies, so I think this makes sense even in the long term. I don't know if you want to automate bumping them, but there are a few stale ones already:
|
Heh thanks. I still need to get familiar with this workflow now. :) I can bump those, though let's do it in a separate PR so we can iterate against a known working base? |
☀️ Test successful - status-atomicjenkins |
|
For the same reasons we started doing it for the main app: coreos#1719 This time, it's `getrand` that broke us.
For the same reasons we started doing it for the main app: coreos#1719 This time, it's `getrand` that broke us. rust-random/getrandom#15 We should be able to update to 1.35.0 soon, which will unblock this.
For the same reasons we started doing it for the main app: coreos#1719 This time, it's `getrand` that broke us. rust-random/getrandom#15 We should be able to update to 1.35.0 soon, which will unblock this.
For the same reasons we started doing it for the main app: #1719 This time, it's `getrand` that broke us. rust-random/getrandom#15 We should be able to update to 1.35.0 soon, which will unblock this. Closes: #1865 Approved by: cgwalters
For the same reasons we started doing it for the main app: #1719 This time, it's `getrand` that broke us. rust-random/getrandom#15 We should be able to update to 1.35.0 soon, which will unblock this. Closes: #1865 Approved by: cgwalters
We've been seeing more breakage recently due to much of the Rust
ecosystem sticking to minimum rustc versions more recent than ours. A
lockfile now means we have to periodically update it, but at least we
have much better control over our CI system and when we want to spend
time resolving package bump conflicts vs. just trying to get a small
patch in.