compose: Support all target repos in unified mode #1657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jlebon
force-pushed
the
pr/unified-auto-bare-user
branch
from
2c42309 to
b9b6ae7
Compare
|
☔ The latest upstream changes (presumably 74db308) made this pull request unmergeable. Please resolve the merge conflicts. |
jlebon
force-pushed
the
pr/unified-auto-bare-user
branch
from
b9b6ae7 to
43ee2b2
Compare
|
Rebased! |
|
This fixes #1490 right? |
This ensures that we always get hardlinks when checking out of the pkgcache. This works right now because we indirectly require the target bare-user repo and the pkgcache to be on the same filesystem by setting `no_copy_fallback` in the core (I say "indirectly" because that setting only enforces the workdir to be on the same filesystem as the pkgcache repo, but since the workdir is currently placed inside the bare-user repo...). However, I'd like to change the requirement of a bare-user repo so that one can commit into a repo on a different file system or a repo of a different type (e.g. archive repo). This is prep for that.
Previously, we were limiting the target repo in unified mode to be a bare-user repo located on the same filesystem (see message of previous commit). This patch lifts this restriction by making a distinction between the *build repo* and the *final* target repo. To do this, we create a bare-user repo located near the pkgcache to take advantage of hardlinks and devino caching at commit time. And only after committing do we essentially `pull-local` into the final target repo. This of course allows us to avoid potentially pulling across the two filesystems file objects that are already present in the target repo. This will be used by coreos-assembler: coreos/coreos-assembler#190 Closes: coreos#1490
jlebon
force-pushed
the
pr/unified-auto-bare-user
branch
from
43ee2b2 to
ea6d835
Compare
|
Rebased, and added |
cgwalters
reviewed
Nov 5, 2018
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 5, 2018
This ensures that we always get hardlinks when checking out of the pkgcache. This works right now because we indirectly require the target bare-user repo and the pkgcache to be on the same filesystem by setting `no_copy_fallback` in the core (I say "indirectly" because that setting only enforces the workdir to be on the same filesystem as the pkgcache repo, but since the workdir is currently placed inside the bare-user repo...). However, I'd like to change the requirement of a bare-user repo so that one can commit into a repo on a different file system or a repo of a different type (e.g. archive repo). This is prep for that. Closes: #1657 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 5, 2018
Previously, we were limiting the target repo in unified mode to be a bare-user repo located on the same filesystem (see message of previous commit). This patch lifts this restriction by making a distinction between the *build repo* and the *final* target repo. To do this, we create a bare-user repo located near the pkgcache to take advantage of hardlinks and devino caching at commit time. And only after committing do we essentially `pull-local` into the final target repo. This of course allows us to avoid potentially pulling across the two filesystems file objects that are already present in the target repo. This will be used by coreos-assembler: coreos/coreos-assembler#190 Closes: #1490 Closes: #1657 Approved by: cgwalters
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 5, 2018
Previously, we were limiting the target repo in unified mode to be a bare-user repo located on the same filesystem (see message of previous commit). This patch lifts this restriction by making a distinction between the *build repo* and the *final* target repo. To do this, we create a bare-user repo located near the pkgcache to take advantage of hardlinks and devino caching at commit time. And only after committing do we essentially `pull-local` into the final target repo. This of course allows us to avoid potentially pulling across the two filesystems file objects that are already present in the target repo. This will be used by coreos-assembler: coreos/coreos-assembler#190 Closes: #1490 Closes: #1657 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes here, but the last two are the major ones. Just going to copy the commit message of the last one here:
Previously, we were limiting the target repo in unified mode to be a
bare-user repo located on the same filesystem (see message of previous
commit). This patch lifts this restriction by making a distinction
between the build repo and the final target repo.
To do this, we create a bare-user repo located near the pkgcache to
take advantage of hardlinks and devino caching at commit time. And only
after committing do we essentially
pull-localinto the final targetrepo. This of course allows us to avoid potentially pulling across the
two filesystems file objects that are already present in the target
repo.
This will be used by coreos-assembler:
coreos/coreos-assembler#190