'rpm-ostree upgrade' isn't reliably printing the result of the upgrade

[miabbott]

Recent attempts to use rpm-ostree upgrade have not been reliably printing the Upgraded/Added/Removed status for the packages affected by the upgrade.

Since a lot has been changing in the internals, I'm guessing this regressed somewhere.

[cgwalters]

I was playing with this:

diff --git a/src/app/rpmostree-builtin-upgrade.c b/src/app/rpmostree-builtin-upgrade.c
index 8c4f027..a86091c 100644
--- a/src/app/rpmostree-builtin-upgrade.c
+++ b/src/app/rpmostree-builtin-upgrade.c
@@ -129,14 +129,14 @@ rpmostree_builtin_upgrade (int             argc,
         goto out;
     }

-  new_default_deployment = rpmostree_os_dup_default_deployment (os_proxy);
-
   if (!rpmostree_transaction_get_response_sync (sysroot_proxy,
                                                 transaction_address,
                                                 cancellable,
                                                 error))
     goto out;

+  new_default_deployment = rpmostree_os_dup_default_deployment (os_proxy);
+
   if (opt_preview || opt_check)
     {
       g_autoptr(GVariant) result = NULL;

Which looks clearly right but that's not it...I think though we may need to drop into the mainloop to process signals.