Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print abbreviated RemovedBasePackages if matching NVRs #1784

Closed
jlebon opened this issue Mar 13, 2019 · 4 comments
Closed

Print abbreviated RemovedBasePackages if matching NVRs #1784

jlebon opened this issue Mar 13, 2019 · 4 comments
Labels
kind/enhancement

Comments

@jlebon
Copy link
Member

jlebon commented Mar 13, 2019

Just something I noticed from looking at #1782. The same way we abbreviate ReplacedBasePackages when there are matching EVR diffs, e.g.

ReplacedBasePackages: foo fooext 1.0-1 -> 1.0-2

We could do something similar for RemovedBasePackages for matching EVRs. Right now we print the full NEVRA of each pkg, e.g.:

RemovedBasePackages: docker-lvm-plugin-2:1.13.1-84.git07f3374.el7.centos.x86_64, docker-client-latest-1.13.1-58.git87f2fab.el7.centos.x86_64, docker-common-2:1.13.1-84.git07f3374.el7.centos.x86_64, docker-2:1.13.1-84.git07f3374.el7.centos.x86_64, docker-novolume-plugin-2:1.13.1-84.git07f3374.el7.centos.x86_64, cockpit-docker-176-4.el7.centos.x86_64, docker-latest-1.13.1-58.git87f2fab.el7.centos.x86_64, docker-client-2:1.13.1-84.git07f3374.el7.centos.x86_64
@r4f4
Copy link
Contributor

r4f4 commented Jun 11, 2019

So the expected output in that case would be

RemovedBasePackages: docker-lvm-plugin docker-common docker docker-client 2:1.13.1-84.git07f3374.el7.centos, docker-client-latest docker-latest 1.13.1-58.git87f2fab.el7.centos, cockpit-docker 176-4.el7.centos

?

@jlebon
Copy link
Member Author

jlebon commented Jun 11, 2019

Yeah, exactly.
Note this isn't super high priority right now, but feel free to work on it if you'd like. :)

r4f4 added a commit to r4f4/rpm-ostree that referenced this issue Jun 11, 2019
@r4f4
status: print abbreviated RemovedBasePackages
6d7d3f5 
The same way we abbreviate ReplacedBasePackages when there are matching
EVR diffs, let's do something similar for RemovedBasePackages for
matching EVRs.

Solves coreos#1784

Signed-off-by: Rafael Fonseca <[email protected]>
@r4f4 r4f4 mentioned this issue Jun 11, 2019
Closed
r4f4 added a commit to r4f4/rpm-ostree that referenced this issue Jun 17, 2019
@r4f4
app/status: Group EVRs for RemovedBasePackages if possible
a64e175 
The same way we abbreviate ReplacedBasePackages when there are matching
EVR diffs, let's do something similar for RemovedBasePackages for
matching EVRs.

Solves coreos#1784

Signed-off-by: Rafael Fonseca <[email protected]>
rh-atomic-bot pushed a commit that referenced this issue Jun 18, 2019
@r4f4 @rh-atomic-bot
app/status: Group EVRs for RemovedBasePackages if possible
d0f90ca 
The same way we abbreviate ReplacedBasePackages when there are matching
EVR diffs, let's do something similar for RemovedBasePackages for
matching EVRs.

Solves #1784

Signed-off-by: Rafael Fonseca <[email protected]>

Closes: #1852
Approved by: jlebon
@r4f4
Copy link
Contributor

r4f4 commented Jul 1, 2019

I guess this could be closed? (d0f90ca)

@jlebon
Copy link
Member Author

jlebon commented Jul 10, 2019

Yes, thanks for working on this!

@jlebon jlebon closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r4f4 @jlebon