Skip to content

Commit

Permalink
core: Fix outdated misleading comment
Browse files Browse the repository at this point in the history
We no longer tell libdnf to add the pkg to the goal until later (because
of rpm-software-management/libdnf#700). Just
tweak those comments to be more explicit about that.

Closes: #1849
Approved by: cgwalters
  • Loading branch information
jlebon authored and rh-atomic-bot committed Jun 6, 2019
1 parent a431728 commit 2a70593
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/libpriv/rpmostree-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1886,7 +1886,7 @@ rpmostree_context_prepare (RpmOstreeContext *self,
g_autoptr(GHashTable) local_pkgs_to_install =
g_hash_table_new_full (g_str_hash, g_str_equal, NULL, g_object_unref);

/* Handle packages to replace */
/* Handle packages to replace; only add them to the sack for now */
g_autoptr(GPtrArray) replaced_nevras = g_ptr_array_new ();
for (char **it = cached_replace_pkgs; it && *it; it++)
{
Expand All @@ -1905,7 +1905,7 @@ rpmostree_context_prepare (RpmOstreeContext *self,
g_hash_table_insert (local_pkgs_to_install, (gpointer)nevra, g_steal_pointer (&pkg));
}

/* For each new local package, tell libdnf to add it to the goal */
/* Now handle local package; only add them to the sack for now */
for (char **it = cached_pkgnames; it && *it; it++)
{
const char *nevra = *it;
Expand Down

0 comments on commit 2a70593

Please sign in to comment.