config.yaml: remove EOL go_versions #180
Conversation
go/tests.yaml
Outdated
| @@ -60,6 +60,7 @@ files: | |||
| go_test_cmd: ./test | |||
| go_generated_dirs: [config, docs] | |||
| go_generate_with_schematyper: true | |||
| go_versions: [1.19.x, 1.20.x, 1.21.x] | |||
There was a problem hiding this comment.
I think instead we should probably be editing the defaults in config.yaml so it applies to all golang projects in this repo?
There was a problem hiding this comment.
Also, looking more closely, we're build with golang v1.20 in Fedora, CentOS Stream, and RHEL (at least for the streams we care about). So I think we can drop v1.19 as well (by the golang support policy, v1.19 is now no longer supported).
There was a problem hiding this comment.
Ah; ok I can do that though I was a little hesitant as it would have implications on other go-repos
I can update those too as well though.
Update the default value for the go_version to only list non-EOL versions. Both 1.18.x and 1.19.x are no longer maintained. Additionally add 1.21.x
prestist
force-pushed
the
update-ignition-go
branch
from
f2129fc
to
d82e36a
Compare
prestist
changed the title
|
Thank you for the feedback; I think I prefer your commit message; but I also think the existing one was satisfactory and did not want to reset any approval. |
Related to this coreos/ignition#1733