This repository has been archived by the owner on May 7, 2021. It is now read-only.
platform: Drop checks for OS IDs #920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 21, 2018
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. For now we hardcode `-b rhcos`...but that should change. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
This was referenced Sep 21, 2018
ajeddeloh
approved these changes
Sep 21, 2018
There was a problem hiding this comment.
Curious what @bgilbert thinks, but lgtm. I asked crawford if there was any history here and he said no. I don't see a good reason for kola to care what it's testing. I suspect it was just a check to make sure if you fat-fingered the ami ID or selected the wrong OS you wouldn't waste time/resources, but that's moot now that there are multiple valid things to test.
Probably drop the comment? It seems like a comment we wouldn't want forever and I don't see a whole lot of good keeping it around for a while.
This way if someone uses e.g. `-b rhcos`, we will believe them and try. Theoretically for example Flatcar should have its own OS ID and set `ID_LIKE=coreos` or so - in general we should also support `ID_LIKE` but that's a distinct path.
cgwalters
force-pushed
the
no-osid-check
branch
from
2df4539 to
ae862c6
Compare
|
OK, now with no comment. |
|
This is okay, but I'd rather have the safety check for the reasons @ajeddeloh mentioned. Could we go ahead and add the additional case for FCOS? |
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 24, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. For now we hardcode `-b rhcos`...but that should change. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 24, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 24, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 24, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 24, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 24, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to jlebon/coreos-assembler
that referenced
this pull request
May 25, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 28, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 29, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
jlebon
pushed a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 29, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
dustymabe
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
May 29, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
ashcrow
pushed a commit
to ashcrow/coreos-assembler
that referenced
this pull request
May 30, 2019
This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way if someone uses e.g.
-b rhcos, we will believe them andtry. Theoretically for example Flatcar should have its own OS ID
and set
ID_LIKE=coreosor so - in general we should also supportID_LIKEbut that's a distinct path.