Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Commit

Permalink
qemu: Always add serial= for disks
Browse files Browse the repository at this point in the history
This is used for device enumeration order, and is required for NVMe
drives apparently.  Hit this while trying to use a NVMe device as
a target for coreos-install testing (not primary disk).
  • Loading branch information
cgwalters committed Feb 24, 2020
1 parent 80e8e1a commit 7383128
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions platform/qemu.go
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,9 @@ func (builder *QemuBuilder) addDiskImpl(disk *Disk, primary bool) error {
diskOpts := disk.DeviceOpts
if primary {
diskOpts = append(diskOpts, "serial=primary-disk")
} else {
// Note that diskId is incremented by addQcow2DiskFd
diskOpts = append(diskOpts, "serial="+fmt.Sprintf("disk%d", builder.diskId))
}
channel := disk.Channel
if channel == "" {
Expand Down

0 comments on commit 7383128

Please sign in to comment.