Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

add new option csrName to specify the csr object's name #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajatchopra
Copy link

@rajatchopra rajatchopra commented Jan 24, 2019

This change should not change any existing behaviour. If the field '--name' is
not specified then the commonname will be used for the object's name (what happens today).
When specified, the objects name will be taken accordingly.

Useful when multiple CSR objects need to be created for the same 'commonname'.

@rajatchopra rajatchopra changed the title add new option csrName to specify the csr object's name [WIP] add new option csrName to specify the csr object's name Jan 24, 2019
…ct's name

This change should not change any existing behaviour. If the field '--csrName' is
not specified then the commonname will be used for the object's name (what happens today).
When specified, the objects name will be taken accordingly. This is useful
when multiple CSR objects need to be created for the same 'commonname'.
@rajatchopra
Copy link
Author

@abhinavdahiya PTAL
When this merges, we will have to update the kube-client-agent image sha here, and other such places.

@rajatchopra rajatchopra changed the title [WIP] add new option csrName to specify the csr object's name add new option csrName to specify the csr object's name Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant