Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/operator-notes: document supported S3 URL formats #1358

Merged
merged 1 commit into from
May 7, 2022
Merged

docs/operator-notes: document supported S3 URL formats #1358

merged 1 commit into from
May 7, 2022

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented May 4, 2022

For #1322. Followup to #1264.

@bgilbert
Copy link
Contributor Author

bgilbert commented May 4, 2022

Hold until I'm able to test every format.

@bgilbert
Copy link
Contributor Author

bgilbert commented May 4, 2022

cc @zeleena

@bgilbert bgilbert marked this pull request as ready for review May 6, 2022 10:24
@bgilbert
Copy link
Contributor Author

bgilbert commented May 6, 2022

Okay, this should be ready to go.

@bgilbert bgilbert mentioned this pull request May 6, 2022
Closed
2 tasks
prestist
prestist approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM

dustymabe
dustymabe approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding docs! I've got a few clarifying questions, but nothing that would hold this up.

docs/operator-notes.md Outdated Show resolved Hide resolved
docs/operator-notes.md Outdated Show resolved Hide resolved
@dustymabe
Copy link
Member

Question.. do we support s3 pre-signed URLs? Should we include an example of them here?

@bgilbert
Copy link
Contributor Author

bgilbert commented May 6, 2022

Question.. do we support s3 pre-signed URLs? Should we include an example of them here?

Those are just HTTP(S) URLs, so they should work but don't have any special semantics.

@bgilbert
Copy link
Contributor Author

bgilbert commented May 7, 2022

That's good feedback, thanks. Updated for comments, simplified the table, and added supported spec versions.

@dustymabe dustymabe mentioned this pull request May 7, 2022
Merged
dustymabe
dustymabe approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert merged commit 427a35b into coreos:main May 7, 2022
@bgilbert bgilbert deleted the aws-docs branch May 7, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestist prestist prestist approved these changes

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgilbert @dustymabe @prestist