This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fix(systemd): Use LinkUnitFiles rather than EnableUnitFiles #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @polvi @jonboulle |
|
why not just drop this all together? What is it doing? |
|
@polvi LinkUnitFiles offloads the work of linking our units from /run/fleet/units into the systemd search path, ignoring the [Install] section. |
|
lgtm |
bcwaldon
added a commit
that referenced
this pull request
May 7, 2014
fix(systemd): Use LinkUnitFiles rather than EnableUnitFiles
lgtm fwiw!Link a unit file that is not in the unit file search paths into the unit file search path. This requires an absolute path to a unit file. The effect of this can be undone with disable. The effect of this command is that a unit file is available for start and other commands although it is not installed directly in the unit search path. |
|
I'm hella confused, thought this was done already ship eeeeet |
|
@jonboulle I had updated go-systemd, but hadnt gotten as far as replacing the call to EnableUnitFiles. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.