This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fleetd: allow users to turn off force flag for systemd.LinkUnitFiles() #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far systemd.LinkUnitFiles() has been called with the force option turned on. That was one of the reasons of performance issues. Let's introduce an option systemd_link_unit_force, false by default. Users can set the option in fleetd.conf. That option will be passed directly to systemd.LinkUnitFiles().
|
What's the actual reason for the bad performance? |
|
@jonboulle According to a report(#1393 (comment)), it's because systemctl link is being executed for each unit. I think the topic was also mentioned in the talk by @hectorj2f at the last CoreOS Fest. |
|
@dongsupark ok, just seems like we could do better at communicating this to users? hinting at why they might want to use it for example |
dongsupark
force-pushed
the
master
branch
3 times, most recently
from
20a3e96 to
3aaa1ab
Compare
dongsupark
force-pushed
the
master
branch
2 times, most recently
from
eb6872f to
365565e
Compare
dongsupark
force-pushed
the
master
branch
6 times, most recently
from
39a99ba to
44591b0
Compare
dongsupark
force-pushed
the
master
branch
3 times, most recently
from
0132632 to
6974811
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far
systemd.LinkUnitFiles()has been called with the force option turned on. That was one of the reasons of performance issues.Let's introduce an option
systemd_link_unit_force, false by default. Users can set the option infleetd.conf. That option will be passed directly tosystemd.LinkUnitFiles()./cc @hectorj2f
Fixes #1694