This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
registry/rpc: re-enable error handling after NewSystemdUnitManage #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run TestRegistryMuxUnitManagement() only when user's euid is 0 and systemd is avilable at run-time. Such a distinction is necessary for avoiding test failures, especially when unit tests run on travis CI, where systemd is not available. With those checks, we can re-enable error handling after calling systemd.NewSystemdUnitManager().
dongsupark
force-pushed
the
dongsu/unit-test-rootuser-systemd
branch
from
3f2cc17
to
2d3000f
Compare
dongsupark
changed the title
dongsupark
force-pushed
the
dongsu/unit-test-rootuser-systemd
branch
2 times, most recently
from
9156dd3
to
c86e6d0
Compare
On Linux syscall.Setuid() is not supported in go. So running unit tests with root privileges fails when calling Setuid. Let's skip the test on Linux, if euid is 0.
|
Last week I changed this PR, to check euid and systemd not in a shell script, but in I'm going to merge this PR in this week, as it fixes real bugs, and it changes only unit tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
TestRegistryMuxUnitManagement()only when user's euid is 0 and systemd is available at run-time. Such a distinction is necessary for avoiding test failures, especially when unit tests run on travis CI, where systemd is not available. With those checks, we can re-enable error handling after callingsystemd.NewSystemdUnitManager().Besides fix also a hidden bug in
TestWrongHostKeyFile()to skip the test on Linux if euid is 0. On Linuxsyscall.Setuid()is not supported in go. So running unit tests with root privileges fails when calling Setuid.