This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
agent: reenable check for nil hash in unit state publisher #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long time ago there were checks for nil unit hashes in agent.UnitStatePublisher.publishOne and registry.UnitStateToModel, but given that units could enter the system without populated hashes, the checks were disabled: 11949e0 ("agent: publish unit state regardless of hash"). However the hashes are now always populated, so the corresponding assertions should be reenabled. Fixes coreos#989
dongsupark
force-pushed
the
dongsu/fleetd-recheck-nil-hash
branch
3 times, most recently
from
8149e9b
to
d77b8e4
Compare
Now that nil UnitHash is not allowed, we need to set a fake unit hash string to each test case in TestDefaultPublisher to avoid test failures.
dongsupark
pushed a commit
that referenced
this pull request
Jul 22, 2016
agent: reenable check for nil hash in unit state publisher
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time ago there were checks for nil unit hashes in
agent.UnitStatePublisher.publishOneandregistry.UnitStateToModel, but given that units could enter the system without populated hashes, the checks were disabled: 11949e0("agent: publish unit state regardless of hash").However the hashes are now always populated, so the corresponding assertions should be reenabled.
Fixes #989