tests: added "fleetctl --tunnel" tests #1492
Conversation
kayrus
force-pushed
the
kayrus/ssh_tests
branch
from
8a62ab6
to
010dc52
Compare
|
Looks like |
|
Yet another test for #565: $ export REMOTE_HOST=localhost
$ eval $(ssh-agent)
$ for i in {1..10}; do (ssh-keygen -t rsa -b 1024 -f $HOME/.ssh/test_rsa_$i -N ''; ssh-add $HOME/.ssh/test_rsa_$i)& done; wait; echo "done"
$ fleetctl -strict-host-key-checking=false --tunnel $REMOTE_HOST list-machines
Unable to initialize client: failed initializing SSH client: ssh: handshake failed: ssh: unexpected message type 1 (expected 52)
$ ssh-agent -k
$ rm $HOME/.ssh/test_rsa_* |
kayrus
force-pushed
the
kayrus/ssh_tests
branch
from
d9552e7
to
cfbb3fc
Compare
kayrus
force-pushed
the
kayrus/ssh_tests
branch
from
6c08547
to
3f3daa2
Compare
|
Trying to find other way to fix this bug. ea415ad is only workaround which doesn't explain cause of the problem |
|
@jonboulle if you accept this fix, let's merge this PR. and I'll try to find proper solution later within new issue. |
| if _, _, err := run(cmd); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| fleetdBinDst := path.Join(dir, "opt", "fleet", "fleetd") | ||
| return copyFile(fleetdBinPath, fleetdBinDst, 0755) | ||
| BinDst := path.Join(dst, "opt", "fleet", path.Base(src)) |
|
Couple of nits but LGTM overall! |
jonboulle
changed the title
|
@tixxdz any remarks or objections? |
* renamed BinDst into binDst * split "Launch one unit" string
kayrus
force-pushed
the
kayrus/ssh_tests
branch
from
3ad2ac2
to
fd6b2f6
Compare
| @@ -30,10 +30,14 @@ import ( | |||
| type SSHForwardingClient struct { | |||
| agentForwarding bool | |||
| *gossh.Client | |||
| agentForwardingEnabled bool | |||
There was a problem hiding this comment.
Ok, one minor: could you please rename this to: authAgentReqSent or agentForwardingSent , but not Enabled, and also put some code comment: "Used to check if we have already sent the request to the ssh channel".
|
@kayrus thank you, please if you could change the name of that variable! then will merge. |
tests: added "fleetctl --tunnel" tests
|
@kayrus ok thank you merged, and thanks also for triggering that "remote: Daily bandwidth rate limit exceeded..." ! |
adding tests which will cover #565 #1425 #1455
closes #1484