-
Notifications
You must be signed in to change notification settings - Fork 302
Conversation
Ah, yeah.
Not putting this neatly in my go path is biting me. |
@miekg we'd like to clean this up and get it merged. What's the reason you removed the jitter stuff? |
[ Quoting [email protected] in "Re: [fleet] Add --disable_watches f..." ]
failing tests... I couldn't (quickly) find wth was happening there. |
Hmm, ok - do you want to squash these commits and we can land as-is then? |
and tweak the commit message :-) |
done. |
@@ -55,3 +55,9 @@ wins: | |||
* Making some defaults exported and allow them to be overridden. For instance | |||
fleet's tokenLimit controls how many Units are listed per "page". *See the | |||
`--token-limit` flag.* | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er, sorry. I thought I commented here but apparently not. Can you remove lines 36-46 from this file?
Setting this flag to true makes fleet not set any watches in etcd. This should aid in making fleet scale better.
lines 36-46 removed. |
@miekg thanks for your patience :-) |
agent: add --disable_watches flag
If changes to schedule state in etcd are the stimulus for fleetd agent to reconcile what needs to be done locally, then what stimulus remains after --disable_watches is enabled? You say that latency increases, but what stimuli remain? Does fleetd also put the agent under some timer? Thanks. |
There is a periodic timer that wakes up the agent every 5 seconds to do On 7 November 2016 at 09:50, Andrew Wald [email protected] wrote:
|
Setting this flag to true makes fleet not set any watches in etcd.