Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add --disable_watches flag #1406

Merged
merged 1 commit into from
Feb 10, 2016
Merged

Conversation

miekg
Copy link
Contributor

@miekg miekg commented Jan 21, 2016

Setting this flag to true makes fleet not set any watches in etcd.

@miekg
Copy link
Contributor Author

miekg commented Jan 21, 2016

Ah, yeah.

  1. Haven't added prometheus dependency in GodepsForgot to add a file.
  2. ./test works. Hasn't seen any production use.

Not putting this neatly in my go path is biting me.

@jonboulle
Copy link
Contributor

@miekg we'd like to clean this up and get it merged. What's the reason you removed the jitter stuff?

@miekg
Copy link
Contributor Author

miekg commented Feb 10, 2016

[ Quoting [email protected] in "Re: [fleet] Add --disable_watches f..." ]

@miekg we'd like to clean this up and get it merged. What's the reason you removed the jitter stuff?

failing tests... I couldn't (quickly) find wth was happening there.

@jonboulle
Copy link
Contributor

Hmm, ok - do you want to squash these commits and we can land as-is then?

@jonboulle
Copy link
Contributor

and tweak the commit message :-)

@miekg
Copy link
Contributor Author

miekg commented Feb 10, 2016

done.

@@ -55,3 +55,9 @@ wins:
* Making some defaults exported and allow them to be overridden. For instance
fleet's tokenLimit controls how many Units are listed per "page". *See the
`--token-limit` flag.*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, sorry. I thought I commented here but apparently not. Can you remove lines 36-46 from this file?

Setting this flag to true makes fleet not set any watches in etcd. This
should aid in making fleet scale better.
@miekg
Copy link
Contributor Author

miekg commented Feb 10, 2016

lines 36-46 removed.

@jonboulle
Copy link
Contributor

@miekg thanks for your patience :-)

jonboulle added a commit that referenced this pull request Feb 10, 2016
agent: add --disable_watches flag
@jonboulle jonboulle merged commit cbbbb23 into coreos:master Feb 10, 2016
@jonboulle jonboulle mentioned this pull request Feb 10, 2016
@anwald
Copy link

anwald commented Nov 7, 2016

If changes to schedule state in etcd are the stimulus for fleetd agent to reconcile what needs to be done locally, then what stimulus remains after --disable_watches is enabled? You say that latency increases, but what stimuli remain? Does fleetd also put the agent under some timer? Thanks.

@jonboulle
Copy link
Contributor

There is a periodic timer that wakes up the agent every 5 seconds to do
this reconciliation.

On 7 November 2016 at 09:50, Andrew Wald [email protected] wrote:

If changes to schedule state in etcd are the stimulus for fleetd agent to
reconcile what needs to be done locally, then what stimulus remains after
--disable_watches is enabled? You say that latency increases, but what
stimuli remain? Does fleetd also put the agent under some timer? Thanks.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1406 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACewN1t8ryPh5gwN5GjYrPu4Fotd7lLVks5q7uZOgaJpZM4HJnaT
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants