Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design: add bucket layout #208

Merged
merged 1 commit into from
Jul 12, 2019
Merged

design: add bucket layout #208

merged 1 commit into from
Jul 12, 2019

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jun 24, 2019

As discussed in #189.

@jlebon jlebon mentioned this pull request Jun 24, 2019
Closed
arithx
arithx reviewed Jun 24, 2019
View reviewed changes
Design.md Outdated Show resolved Hide resolved
sinnykumari
sinnykumari reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Design.md Outdated Show resolved Hide resolved
@jlebon jlebon force-pushed the pr/bucket-layout branch from a7e1aed to 92f449d Compare June 26, 2019 13:58
@jlebon
Copy link
Member Author

jlebon commented Jun 26, 2019

I renamed it to releases.json to match 79d830b. ⬆️

sinnykumari
sinnykumari reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

Design.md Outdated Show resolved Hide resolved
@jlebon jlebon force-pushed the pr/bucket-layout branch from 92f449d to 76efaaa Compare July 2, 2019 14:15
bgilbert
bgilbert reviewed Jul 8, 2019
View reviewed changes
Design.md Outdated Show resolved Hide resolved
Design.md Outdated Show resolved Hide resolved
bgilbert
bgilbert reviewed Jul 11, 2019
View reviewed changes
Design.md Outdated Show resolved Hide resolved
@jlebon jlebon force-pushed the pr/bucket-layout branch from 76efaaa to 9242905 Compare July 12, 2019 01:39
bgilbert
bgilbert approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinnykumari
sinnykumari approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinnykumari sinnykumari mentioned this pull request Jul 12, 2019
Closed
@jlebon jlebon merged commit ae07d8a into coreos:master Jul 12, 2019
@jlebon jlebon mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithx arithx arithx left review comments

@sinnykumari sinnykumari sinnykumari approved these changes

@bgilbert bgilbert bgilbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlebon @bgilbert @sinnykumari @arithx