Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all repos to peter-evans/[email protected] #1699

Closed
jlebon opened this issue Mar 25, 2024 · 8 comments
Closed

Update all repos to peter-evans/[email protected] #1699

jlebon opened this issue Mar 25, 2024 · 8 comments
Assignees
Labels
jira for syncing to jira

Comments

@jlebon
Copy link
Member

jlebon commented Mar 25, 2024

We're hitting a known issue that has been fixed in v6.0.1.

All instances where we use this action: https://github.com/search?q=org%3Acoreos+%22uses%3A+peter-evans%2Fcreate-pull-request%22&type=code

None of the breaking changes should affect us, so we should be good to just bump to v6.0.2.

@aaradhak aaradhak self-assigned this Mar 25, 2024
@aaradhak aaradhak added the jira for syncing to jira label Mar 25, 2024
@travier
Copy link
Member

travier commented Mar 26, 2024

Ideally, we should setup depandabot as well to get those updates in automatically. Example in https://github.com/travier/fedora-kinoite/blob/main/.github/dependabot.yml

@travier
Copy link
Member

travier commented Mar 26, 2024

@jlebon
Copy link
Member Author

jlebon commented Apr 4, 2024

Ideally, we should setup depandabot as well to get those updates in automatically. Example in travier/fedora-kinoite@main/.github/dependabot.yml

Mayyybe. If it's bumping across major versions, you can't just merge as is. You have to check what breaking changes happened and verify that it doesn't apply to you. And of course for the workflows we're talking about here, it's not really tested by CI.

If it's bumping within major versions, then we don't need Dependabot for that; we just have to pin to a major version and not be more specific (e.g. peter-evans/create-pull-request@v6).

@aaradhak
Copy link
Member

aaradhak commented Apr 5, 2024

So do we just bump to peter-evans/[email protected] without setting up the dependabot ?

Ideally, we should setup depandabot as well to get those updates in automatically. Example in travier/fedora-kinoite@main/.github/dependabot.yml

Mayyybe. If it's bumping across major versions, you can't just merge as is. You have to check what breaking changes happened and verify that it doesn't apply to you. And of course for the workflows we're talking about here, it's not really tested by CI.

If it's bumping within major versions, then we don't need Dependabot for that; we just have to pin to a major version and not be more specific (e.g. peter-evans/create-pull-request@v6).

@jlebon
Copy link
Member Author

jlebon commented Apr 10, 2024

So do we just bump to peter-evans/[email protected] without setting up the dependabot ?

How about for now bumping to peter-evans/create-pull-request@v6? That'll give us minor version tracking and we could down the line set up Dependabot for major version bumps if we feel it's worth it.

aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Apr 10, 2024
aaradhak added a commit to aaradhak/layering-examples that referenced this issue Apr 10, 2024
aaradhak added a commit to aaradhak/fedora-coreos-docs that referenced this issue Apr 10, 2024
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this issue Apr 10, 2024
aaradhak added a commit to aaradhak/repo-templates that referenced this issue Apr 10, 2024
@jlebon
Copy link
Member Author

jlebon commented Apr 10, 2024

@aaradhak All of those PRs are bumping the GHA to v6.0.2, but in #1699 (comment), my suggestion was to bump to v6 instead. Was that on purpose?

aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Apr 11, 2024
aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Apr 11, 2024
aaradhak added a commit to aaradhak/repo-templates that referenced this issue Apr 11, 2024
aaradhak added a commit to aaradhak/repo-templates that referenced this issue Apr 11, 2024
aaradhak added a commit to aaradhak/layering-examples that referenced this issue Apr 11, 2024
aaradhak added a commit to aaradhak/fedora-coreos-docs that referenced this issue Apr 11, 2024
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this issue Apr 11, 2024
@aaradhak
Copy link
Member

aaradhak commented Apr 11, 2024

@jlebon I was trying to look into the difference between v6.0.0 and v6.0.2. I have updated to v6.0.0 now.

aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Apr 12, 2024
aaradhak added a commit to aaradhak/layering-examples that referenced this issue Apr 12, 2024
aaradhak added a commit to aaradhak/repo-templates that referenced this issue Apr 12, 2024
aaradhak added a commit to aaradhak/fedora-coreos-docs that referenced this issue Apr 12, 2024
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this issue Apr 12, 2024
jlebon pushed a commit to coreos/fedora-coreos-docs that referenced this issue Apr 12, 2024
jlebon pushed a commit to coreos/fedora-coreos-config that referenced this issue Apr 12, 2024
jlebon pushed a commit to coreos/fedora-coreos-streams that referenced this issue Apr 12, 2024
@jlebon
Copy link
Member Author

jlebon commented Apr 16, 2024

This is done now. Thanks @aaradhak!

@jlebon jlebon closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira for syncing to jira
Projects
None yet
Development

No branches or pull requests

3 participants