Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importer: start validating response from service #97

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Apr 17, 2020

The importer is fully up and running now, so let's start checking that
it correctly imported the commit and error out if an error occurred.

jlebon added 2 commits April 17, 2020 11:32
Simple `s/Signing/Importing/`.
The importer is fully up and running now, so let's start checking that
it correctly imported the commit and error out if an error occurred.
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit 56cd9a0 into coreos:master Apr 17, 2020
@jlebon jlebon deleted the pr/validate-importer-response branch April 17, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants