Jenkinsfile: stop ignoring kola errors #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that coreos/mantle#1059 is fixed (see coreos/mantle#1153), we can use the new `--no-test-exit-error` switch to be more strict about kola error handling. This way, we immediately fail the build if something fundamental went wrong with kola.
|
Requires: coreos/coreos-assembler#1058 |
dustymabe
approved these changes
Jan 15, 2020
|
will we still get the tarball of the logs? |
cgwalters
approved these changes
Jan 15, 2020
Yeah, everything else stays the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that coreos/mantle#1059 is fixed (see
coreos/mantle#1153), we can use the new
--no-test-exit-errorswitch to be more strict about kola errorhandling.
This way, we immediately fail the build if something fundamental went
wrong with kola.