Jenkinsfile.*: consistently substitute COREOS_ASSEMBLER_MEMORY_REQUEST #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only doing it in the main Jenkinsfile, but many of the other ones use the same `pod.yaml` definition so we need to sub out that variable there too. In the future, I'd like to switch all jobs over to [coreos-ci-lib](https://github.com/coreos/coreos-ci-lib) instead to make this less error-prone and only actually mount the secrets each job needs.
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only doing it in the main Jenkinsfile, but many of the other
ones use the same
pod.yamldefinition so we need to sub out thatvariable there too.
In the future, I'd like to switch all jobs over to
coreos-ci-lib instead to make
this less error-prone and only actually mount the secrets each job
needs.