Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop multipath-generator #433

Merged
merged 1 commit into from
May 28, 2020
Merged

Drop multipath-generator #433

merged 1 commit into from
May 28, 2020

Conversation

darkmuggle
Copy link
Contributor

The multipath generator was a nice idea to help make things automatic
based on rd.multipath=default. However, changes in Ignition Dracut and
the direction of using explict kargs makes this well-intentioned module
cruft.

See: coreos/fedora-coreos-tracker#465

The multipath generator was a nice idea to help make things automatic
based on `rd.multipath=default`. However, changes in Ignition Dracut and
the direction of using explict kargs makes this well-intentioned module
cruft.

See: coreos/fedora-coreos-tracker#465
@darkmuggle
Copy link
Contributor Author

Users wishing to use multipath will need to do rd.mutlipath=default root=/dev/disk/by-label/dm-mpath-root

@cgwalters
Copy link
Member

I'm always in favor of less shell script run as root!

Having things be more explicit makes sense to me.

I am wondering though how mpath will interact with rootfs reprovisioning, but perhaps that code can do "use current root= arg if present, otherwise just /dev/disk/by-label/root".

@darkmuggle
Copy link
Contributor Author

I am wondering though how mpath will interact with rootfs reprovisioning, but perhaps that code can do "use current root= arg if present, otherwise just /dev/disk/by-label/root".

See: https://github.com/coreos/fedora-coreos-config/blob/testing-devel/overlay.d/05core/usr/lib/udev/rules.d/90-coreos-device-mapper.rules#L19-L23

For root reprovisioning, then would have to use /dev/mapper/mpatha

@darkmuggle darkmuggle merged commit 024aa90 into coreos:testing-devel May 28, 2020
@jlebon
Copy link
Member

jlebon commented May 28, 2020

A bit late, but LGTM!
I think we can also remove the sysroot.env bits too with this.

c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
Bump fedora-coreos-config to get ordering cycle fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants