Enable cliwrap (rawhide only for now) #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cliwrap code has existed for a long, long time. However, things change now with the advent of ostree-native containers. I think it Just Makes Sense to enable `yum install foo` inside an ostree container, which the code now does when this flag is enabled. This will *also* cause the cliwrap code to appear on the host, but I think that's less confusing than not doing so.
|
This is a retry now that coreos/rpm-ostree#3737 landed in rawhide. |
|
I verified here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cliwrap code has existed for a long, long time. However,
things change now with the advent of ostree-native containers.
I think it Just Makes Sense to enable
yum install fooinsidean ostree container, which the code now does when this flag is enabled.
This will also cause the cliwrap code to appear on the host, but
I think that's less confusing than not doing so.