Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rawhide] Switch to ostree-format: "oci" #1097

Merged
merged 1 commit into from
Jul 22, 2021
Merged

[rawhide] Switch to ostree-format: "oci" #1097

merged 1 commit into from
Jul 22, 2021

Conversation

cgwalters
Copy link
Member

Part of coreos/fedora-coreos-tracker#812

In this initial step, we're merely switching the internal
tarball to be a different format.

A future step will change the FCOS pipeline to automatically
push this container to quay.io.

@cgwalters
Switch to ostree-format: "oci"
f886690 
Part of coreos/fedora-coreos-tracker#812

In this initial step, we're merely switching the internal
tarball to be a different format.

A future step will change the FCOS pipeline to automatically
push this container to quay.io.
@cgwalters cgwalters changed the title Switch to ostree-format: "oci" [rawhide] Switch to ostree-format: "oci" Jul 9, 2021
@cgwalters cgwalters mentioned this pull request Jul 9, 2021
Closed
kelvinfan001
kelvinfan001 approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@kelvinfan001 kelvinfan001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

two questions:

  • Does this have any implications for things that currently use it (I think our upgrade tests use it)?
  • I agree that we shouldn't make this change to testing-devel (new releases early next week) but.. Any reason to only be doing this for rawhide?

@jlebon
Copy link
Member

jlebon commented Jul 13, 2021

two questions:

  • Does this have any implications for things that currently use it (I think our upgrade tests use it)?

Good catch! Indeed, we'll need to adapt the upgrade test for this.

  • I agree that we shouldn't make this change to testing-devel (new releases early next week) but.. Any reason to only be doing this for rawhide?

I think for this type of stuff it makes a lot of sense to start off on mechanical streams before propagating to development and then production streams. I don't see a reason why we wouldn't propagate once it's sanity-checked in rawhide. (I guess at some point we should just flip the cosa default?)

@cgwalters cgwalters added the jira For syncing to Jira. Only works for issues (i.e. not PRs) label Jul 16, 2021
@cgwalters cgwalters marked this pull request as draft July 16, 2021 16:22
@cgwalters
Copy link
Member Author

OK this blocks on coreos/coreos-assembler#2300

@cgwalters cgwalters marked this pull request as ready for review July 22, 2021 17:06
@cgwalters cgwalters closed this Jul 22, 2021
@cgwalters cgwalters reopened this Jul 22, 2021
@cgwalters cgwalters merged commit e7ef64d into coreos:rawhide Jul 22, 2021
@cgwalters cgwalters mentioned this pull request Jul 22, 2021
Closed
@dustymabe
Copy link
Member

I see an issue in rawhide building - possibly related to this?

No apparent changes since previous commit; use --force-nocache to override
commit: cac48abcb84ddade31b949e77ba4fd7db158d5c2bba909ef0f6c4f2f89fc1fc1 image: ace11605cf595bdb025d8aeb6934f2f7d070c72397ca59513c6570a10f2964c8
Commit cac48abcb84ddade31b949e77ba4fd7db158d5c2bba909ef0f6c4f2f89fc1fc1 unchanged; reusing previous build's rpm-ostree metadata
ostree diff commit from: cac48abcb84ddade31b949e77ba4fd7db158d5c2bba909ef0f6c4f2f89fc1fc1
ostree diff commit to:   cac48abcb84ddade31b949e77ba4fd7db158d5c2bba909ef0f6c4f2f89fc1fc1
New image input checksum: ace11605cf595bdb025d8aeb6934f2f7d070c72397ca59513c6570a10f2964c8
None
New build ID: 35.20210722.91.0-1
error: Building oci: Writing ostree root to blob: Exporting commit: No such metadata object 50773817e4519629fb061cb3cfe4ddae0a996c12336d087042481fbeab1a380c.dirmeta
script returned exit code 1

https://jenkins-fedora-coreos.apps.ocp.ci.centos.org/blue/organizations/jenkins/fedora-coreos%2Ffedora-coreos-fedora-coreos-pipeline/detail/fedora-coreos-fedora-coreos-pipeline/2246/pipeline

@cgwalters
Copy link
Member Author

I suspect this is just ye olde coreos/coreos-assembler#972

@dustymabe dustymabe mentioned this pull request Jul 26, 2021
Closed
cgwalters added a commit to cgwalters/os that referenced this pull request Jul 26, 2021
@cgwalters
image: Switch to ostree-format: oci
8e0a9d2 
This is the RHCOS version of coreos/fedora-coreos-config#1097

I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.

NOTE!  This **does not change** the effect of `cosa upload-oscontainer` etc.
Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.

However, what this *will* do is allow us to push this *additional* image
arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g.
work.  In other words to start this will just be something *we* use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
 http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
 instead of the existing `ostree.tar` so in theory other people outside
 of our group could run it too, but 🤫)
@cgwalters cgwalters mentioned this pull request Jul 26, 2021
Merged
cgwalters added a commit to cgwalters/os that referenced this pull request Aug 30, 2021
@cgwalters
image: Switch to ostree-format: oci
7a4d1bc 
This is the RHCOS version of coreos/fedora-coreos-config#1097

I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.

NOTE!  This **does not change** the effect of `cosa upload-oscontainer` etc.
Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.

However, what this *will* do is allow us to push this *additional* image
arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g.
work.  In other words to start this will just be something *we* use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
 http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
 instead of the existing `ostree.tar` so in theory other people outside
 of our group could run it too, but 🤫)
@cgwalters cgwalters mentioned this pull request Aug 30, 2021
Merged
@cgwalters cgwalters mentioned this pull request Sep 7, 2021
Merged
cgwalters added a commit to cgwalters/os that referenced this pull request Sep 8, 2021
@cgwalters
image: Switch to ostree-format: oci
4d62fea 
This is the RHCOS version of coreos/fedora-coreos-config#1097

I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.

NOTE!  This **does not change** the effect of `cosa upload-oscontainer` etc.
Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.

However, what this *will* do is allow us to push this *additional* image
arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g.
work.  In other words to start this will just be something *we* use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
 http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
 instead of the existing `ostree.tar` so in theory other people outside
 of our group could run it too, but 🤫)
@cgwalters cgwalters mentioned this pull request Sep 8, 2021
Merged
@cgwalters cgwalters mentioned this pull request Sep 24, 2021
Closed
ravanelli pushed a commit to ravanelli/os that referenced this pull request Oct 5, 2021
@cgwalters @ravanelli
image: Switch to ostree-format: oci
05f137a 
This is the RHCOS version of coreos/fedora-coreos-config#1097

I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.

NOTE!  This **does not change** the effect of `cosa upload-oscontainer` etc.
Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.

However, what this *will* do is allow us to push this *additional* image
arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g.
work.  In other words to start this will just be something *we* use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
 http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
 instead of the existing `ostree.tar` so in theory other people outside
 of our group could run it too, but 🤫)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinfan001 kelvinfan001 kelvinfan001 approved these changes

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
jira For syncing to Jira. Only works for issues (i.e. not PRs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgwalters @dustymabe @jlebon @kelvinfan001