-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overrides: fast-track Ignition 2.11.0-2.fc34 #1096
Conversation
Move ignition-firstboot-complete and ignition-setup-user services to fedora-coreos-config.
ignition: | ||
evr: 2.11.0-2.fc34 | ||
metadata: | ||
type: fast-track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not need the bodhi URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed fast-tracks without the URL before, following the instructions in the comment block. Is there a general preference here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot doesn't need it. It's purely for humans. I personally put it so that it's easy for reviewers to tell that it exists and we won't carry it forever. In this instance, I just manually checked myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, cool. If we generally want it, should we update the header comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that would be nice. I do find the bodhi URL really useful especially when tracking the status manually. i.e. "we've been waiting more than a week for this thing to filter into the stable repos, what's the holdup?" then you check and see the update has negative feedback or something and we need to reconsider our stance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See discussion in #1096 (review).
Move
ignition-firstboot-complete
andignition-setup-user
services to fedora-coreos-config.