Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay/05core: Add a new /usr/lib/coreos/generator-lib.sh #1026

Merged

Conversation

cgwalters
Copy link
Member

Hopefully in the future we'll create a nice rdcore like Rust
place for our generators.

For now let's factor out a little helper library.

@cgwalters cgwalters force-pushed the shared-shell-generator-lib branch from b46ea0e to 00675de Compare May 19, 2021 19:08
@cgwalters cgwalters changed the title overlay/05core: Add a new /usr/li/coreos-shell-generator overlay/05core: Add a new /usr/lib/coreos-shell-generator May 19, 2021
@cgwalters
Copy link
Member Author

Followup to discussion in #1022

jlebon
jlebon previously approved these changes May 19, 2021
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea makes sense to me!

Hopefully in the future we'll create a nice `rdcore` like Rust
place for our generators.

For now let's factor out a little helper library.
@cgwalters cgwalters force-pushed the shared-shell-generator-lib branch from 00675de to bc9bcd3 Compare May 20, 2021 00:26
@jlebon jlebon changed the title overlay/05core: Add a new /usr/lib/coreos-shell-generator overlay/05core: Add a new /usr/lib/coreos/generator-lib.sh May 20, 2021
@cgwalters cgwalters merged commit 1fc7cd9 into coreos:testing-devel May 20, 2021
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants