Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop coreos-cleanup-ignition-config.service after the next barrier release on all streams #1094

Closed
Tracked by #884
bgilbert opened this issue Jul 8, 2021 · 2 comments · Fixed by #1336
Closed
Tracked by #884

Drop coreos-cleanup-ignition-config.service after the next barrier release on all streams #1094

bgilbert opened this issue Jul 8, 2021 · 2 comments · Fixed by #1336
Labels
enhancement New feature or request

Comments

@bgilbert
Copy link
Contributor

bgilbert commented Jul 8, 2021 •
edited
Loading

Ignition will now automatically remove /boot/ignition on first boot, so coreos-cleanup-ignition-config.service only needs to handle old nodes. Once all of those have passed through a barrier, we can revert #1093.

For coreos/fedora-coreos-tracker#889.
@bgilbert bgilbert added the enhancement New feature or request label Jul 8, 2021
@bgilbert bgilbert mentioned this issue Jul 8, 2021
Closed
@dustymabe
Copy link
Member

Should we add this to the checklist in coreos/fedora-coreos-tracker#884 ?

@bgilbert bgilbert mentioned this issue Sep 22, 2021
Closed
30 tasks
@bgilbert
Copy link
Contributor Author

@dustymabe Done.

@bgilbert bgilbert mentioned this issue Nov 9, 2021
Merged
jlebon pushed a commit that referenced this issue Nov 23, 2021
@bgilbert @jlebon
Revert "overlay: remove /boot/ignition on upgrade if present"
c832e4e 
This was a fixup for existing nodes on upgrade.  Now that we've passed
through the F35 barrier release, drop the fixup.

Fixes #1094.

This reverts commit 6e178e7.
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@bgilbert @HuijingHei
Revert "overlay: remove /boot/ignition on upgrade if present"
2022bf5 
This was a fixup for existing nodes on upgrade.  Now that we've passed
through the F35 barrier release, drop the fixup.

Fixes coreos#1094.

This reverts commit 6e178e7.
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@bgilbert @HuijingHei
Revert "overlay: remove /boot/ignition on upgrade if present"
591581a 
This was a fixup for existing nodes on upgrade.  Now that we've passed
through the F35 barrier release, drop the fixup.

Fixes coreos#1094.

This reverts commit 6e178e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "overlay: remove /boot/ignition on upgrade if present"
2 participants
@bgilbert @dustymabe