Skip to content

Commit

Permalink
transposefs: Only autosave-xfs for much larger filesystems
Browse files Browse the repository at this point in the history
The change in #2320
has been very problematic for OpenShift because our default node
configuration is *always* over the threshold, and that causes
significant latency on instance provisioning.

Experimentally bumping to 400 allocation groups, which is about 700GiB.
This is comfortably about the default OpenShift node root disk sizes,
and returns us to the prior status quo.

While we're here, rework the logging a bit so that we *always*
log the `agcount` for debugging purposes.
  • Loading branch information
cgwalters committed Aug 25, 2023
1 parent 33e40a6 commit 65b8bb6
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,20 @@ should_autosave_rootfs() {
return
fi
local agcount
# We want to run xfs_info on the unmounted filesystem, because actually just
# even mounting an XFS filesystem that has grown an excessive number of allocation groups
# can be very slow.
eval $(xfs_info "${root_part}" | grep -o 'agcount=[0-9]*')
# Semi-arbitrarily chosen: this is roughly ~64G currently (based on initial
# ag sizing at build time) which seems like a good rootfs size at which to
# This is roughly ~700GiB currently (based on initial ag sizing at build time) which
# seems like a good rootfs size at which to
# discriminate between "throwaway/short-lived systems" and "long-running
# workload systems". It's not like XFS performance is way worse at 128.
if [ "$agcount" -lt 128 ]; then
echo "Filesystem agcount is $agcount; skipping" >&2
# workload systems". Specifically for e.g. OpenShift, it's below the default node
# sizes.
local threshold
threshold=400
echo "${root_part} agcount=$agcount" >&2
if [ "$agcount" -lt "${threshold}" ]; then
echo "agcount=$agcount is lower than threshold=${threshold}"
echo 0
return
fi
Expand Down
7 changes: 5 additions & 2 deletions tests/kola/root-reprovision/autosave-xfs/test.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
#!/bin/bash
## kola:
## # This test reprovisions the rootfs automatically.
## # Tests: ignition-ostree-transposefs-autosave-xfs.service
## tags: "platform-independent reprovision"
## # Trigger automatic XFS reprovisioning
## minDisk: 100
## # Trigger automatic XFS reprovisioning (heuristic)
## minDisk: 1000
## # Root reprovisioning requires at least 4GiB of memory.
## minMemory: 4096
## # This test includes a lot of disk I/O and needs a higher
Expand All @@ -19,6 +20,8 @@ set -xeuo pipefail
if [ ! -f /run/ignition-ostree-autosaved-xfs.stamp ]; then
fatal "expected autosaved XFS"
fi
# Verify we printed something about the agcount
journalctl -u ignition-ostree-transposefs-autosave-xfs.service --grep=agcount
ok "autosaved XFS on large disk"

eval $(xfs_info / | grep -o 'agcount=[0-9]*')
Expand Down

0 comments on commit 65b8bb6

Please sign in to comment.